Fix/settings design #484
Fix/settings design #484
Conversation
| @@ -17,7 +16,7 @@ import type { Navigator } from '../../../../types/ReactNativeNavigation'; | |||
| import type { Account } from '../../../../types/Account'; | |||
| import i18n from '../../../../global/i18n'; | |||
| import ScreenTitle from '../../../../components/common/ScreenTitle'; | |||
| import Button from '../../../../components/common/Button'; | |||
| // import Button from '../../../../components/common/Button'; | |||
There was a problem hiding this comment.
Please remove it or uncomment
| @@ -93,13 +92,6 @@ class ProfileScreen extends NavigatorComponent<Props> { | |||
| } | |||
| } | |||
|
|
|||
| sharePublicKey = () => { | |||
There was a problem hiding this comment.
Did you move it from there intentionally? It cause things like that:
.
This button shouldn't be on edit profile I think. That's why it was on that screen and not on the parent one.
There was a problem hiding this comment.
@seland ok, this was because, if we put the button in the child it takes a bit of padding on both sides. Putting in parent makes the button span the whole width. But you are right, I need to take care of the edit profile part too. Because both are part of the parent component.
There was a problem hiding this comment.
How about setting the flag editingAccount === null for the button so that it does not render in the EditProfile page?
Fix/settings design Former-commit-id: 46ac781
Changes
• Changed button style of Settings Screen
• Changed arrow design of FlatList