blockchain.getBlock, getBlockHeight, getBlockHash #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canonbrother
requested review from
fullstackninja864,
fuxingloh and
thedoublejay
as code owners
|
Deploy preview for jellyfish-defi ready! Built with commit 7daa3ff |
size-limit report 📦
|
fuxingloh
suggested changes
Apr 1, 2021
packages/jellyfish-api-core/__tests__/category/blockchain.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/blockchain.test.ts
Outdated
Show resolved
Hide resolved
fuxingloh
reviewed
Apr 1, 2021
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 93.46% 93.53% +0.07%
==========================================
Files 16 16
Lines 260 263 +3
Branches 30 30
==========================================
+ Hits 243 246 +3
Misses 15 15
Partials 2 2
Continue to review full report at Codecov.
|
fuxingloh
suggested changes
Apr 2, 2021
packages/jellyfish-api-core/__tests__/category/blockchain.test.ts
Outdated
Show resolved
Hide resolved
- renamed RawTx to Transaction since its actually Transaction in this case - documented each verbosity and make it non-optional, you have to specific verbosity. - updated website with the latest changes
fuxingloh
approved these changes
Apr 5, 2021
fuxingloh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Implemented type for RPC: #48