Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuxingloh/rpc blockchain getblock #92

Merged
merged 1 commit into from
Apr 5, 2021
Merged

fuxingloh/rpc blockchain getblock #92

merged 1 commit into from
Apr 5, 2021

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented Apr 2, 2021 •
edited
Loading

  • isolated and removed all possible race conditions from test so that you can run them separately without relying on each other
  • renamed RawTx to Transaction since its actually Transaction in this case, raw is hex coded data.
  • documented each verbosity and make it non-optional, you have to specific verbosity for better typing support.
  • moved all test notes/comments into the test name for better test clarity. it('')
  • updated website with the latest changes

@fuxingloh
- isolated and removed all possible race conditions from test
46373b2 
- renamed RawTx to Transaction since its actually Transaction in this case
- documented each verbosity and make it non-optional, you have to specific verbosity.
- updated website with the latest changes
@fuxingloh fuxingloh requested a review from canonbrother April 2, 2021 15:48
@fuxingloh fuxingloh marked this pull request as ready for review April 2, 2021 15:48
@canonbrother canonbrother merged commit 7daa3ff into canonbrother/rpc-blockchain-getblock Apr 5, 2021
@canonbrother canonbrother deleted the fuxingloh/rpc-blockchain-getblock branch April 5, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedoublejay thedoublejay thedoublejay approved these changes

@canonbrother canonbrother canonbrother approved these changes

Assignees

@canonbrother canonbrother

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fuxingloh @canonbrother @thedoublejay