sendTokensToAddress RPC

[siradji]

What kind of PR is this?:

/kind feature
What this PR does / why we need it:

Add sendTokensToAddress RPC
Which issue(s) does this PR fixes?:

Fixes part of #48
Additional comments?

[codeclimate]

Code Climate has analyzed commit 65b56b0 and detected 0 issues on this pull request.

View more on Code Climate.

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
packages/jellyfish/dist/index.umd.js	20.48 KB (+0.56% 🔺)	410 ms (+0.56% 🔺)	168 ms (-0.8% 🔽)	578 ms

[siradji]

Behavior

Test fails when source address is provided but passes when an empty object is passed.

Fails at

  it('should create a transaction with source address provided', async () => {
    const to = await client.wallet.getNewAddress()
    const from = await client.wallet.getNewAddress()
    const transactionHex = await client.account.sendTokensToAddress({ [from]: '2@DFI' }, { [to]: '10@DBTC' })

    expect(typeof transactionHex).toStrictEqual('string')
  })

Error

[netlify]

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 1d81213

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60d047ced1f0420008ebce48

😎 Browse the preview: https://deploy-preview-323--jellyfish-defi.netlify.app

[codecov]

Codecov Report

Merging #323 (4f66bb1) into main (116bcdb) will increase coverage by 0.15%.
The diff coverage is 99.42%.

❗ Current head 4f66bb1 differs from pull request most recent head 65b56b0. Consider uploading reports for the commit 65b56b0 to get more accurate results

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   97.06%   97.21%   +0.15%     
==========================================
  Files          92       94       +2     
  Lines        2589     2696     +107     
  Branches      329      346      +17     
==========================================
+ Hits         2513     2621     +108     
+ Misses         76       75       -1     

Impacted Files	Coverage Δ
...ckages/jellyfish-api-core/src/category/poolpair.ts	100.00% <ø> (ø)
packages/jellyfish-transaction/src/index.ts	100.00% <ø> (ø)
...ckages/jellyfish-transaction/src/script/mapping.ts	96.66% <ø> (ø)
packages/jellyfish-transaction/src/tx_segwit.ts	100.00% <ø> (ø)
packages/jellyfish/src/index.ts	100.00% <ø> (ø)
...tcontainers/src/chains/reg_test_container/index.ts	100.00% <ø> (ø)
...kages/testcontainers/src/chains/defid_container.ts	93.06% <85.71%> (-0.69%)	⬇️
...ackages/jellyfish-api-core/src/category/account.ts	100.00% <100.00%> (ø)
...ages/jellyfish-api-core/src/category/blockchain.ts	100.00% <100.00%> (ø)
packages/jellyfish-api-core/src/category/oracle.ts	100.00% <100.00%> (ø)
... and 30 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116bcdb...65b56b0. Read the comment docs.

[fuxingloh]

Take note of conflicts too.

[canonbrother]

i'm good overall

[fuxingloh]

1. take note of small details
2. improve on code testing, don't declare and use a global variable if you don't have to, use additional describe blocks if you need to.

[fuxingloh]

refactor your test

[fuxingloh]

thanks this looks great ❤️