Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed test in getChainTips RPC #327

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Fix failed test in getChainTips RPC #327

merged 2 commits into from
Jun 2, 2021

Conversation

jingyi2811
Copy link
Contributor

@jingyi2811 jingyi2811 commented Jun 1, 2021

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

Fix fail test in getChainTips RPC which happens occasionally.

Which issue(s) does this PR fixes?:

Fixes #326

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Jun 1, 2021

Code Climate has analyzed commit df89947 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.6 KB (0%) 393 ms (0%) 179 ms (+2.8% 🔺) 571 ms

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #327 (df89947) into main (6554eff) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   97.05%   97.09%   +0.03%     
==========================================
  Files          91       91              
  Lines        2514     2545      +31     
  Branches      319      323       +4     
==========================================
+ Hits         2440     2471      +31     
  Misses         74       74              
Impacted Files Coverage Δ
...ellyfish-transaction/src/buffer/buffer_composer.ts 99.48% <100.00%> (+0.01%) ⬆️
...ages/jellyfish-transaction/src/script/defi/dftx.ts 97.36% <100.00%> (+0.07%) ⬆️
...jellyfish-transaction/src/script/defi/dftx_pool.ts 100.00% <100.00%> (ø)
...ckages/jellyfish-transaction/src/script/mapping.ts 96.59% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e7f9c...df89947. Read the comment docs.

@jingyi2811
Copy link
Contributor Author

The test passed in the local environment.
However, it fails in GitHub occasionally.
To ensure the new code is working, I rerun the test four times and all passed.

@jingyi2811 jingyi2811 marked this pull request as ready for review June 1, 2021 13:41
@jingyi2811 jingyi2811 changed the title Fix fail test in getChainTips RPC Fix failed test in getChainTips RPC Jun 1, 2021
@jingyi2811
Copy link
Contributor Author

jingyi2811 commented Jun 1, 2021

I merge this branch to #323 (The branch that Suraj faced this failed test)
and run the test 4 times. All passed.

Reverted back the code after testing

@fuxingloh fuxingloh enabled auto-merge (squash) June 2, 2021 03:42
@fuxingloh fuxingloh disabled auto-merge June 2, 2021 03:49
@fuxingloh fuxingloh merged commit 23d0cb4 into main Jun 2, 2021
@fuxingloh fuxingloh deleted the jimmy/getChainTips branch June 2, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression in getChainTips test
3 participants