Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DfTx PoolUpdatePair #314

Merged
merged 7 commits into from
Jun 1, 2021
Merged

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented May 29, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes part of #108

@codeclimate
Copy link

codeclimate bot commented May 29, 2021

Code Climate has analyzed commit fdd5346 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented May 29, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.6 KB (0%) 393 ms (0%) 166 ms (+1.03% 🔺) 558 ms

@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #314 (fdd5346) into main (31ec934) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   96.98%   97.09%   +0.10%     
==========================================
  Files          90       91       +1     
  Lines        2454     2543      +89     
  Branches      312      323      +11     
==========================================
+ Hits         2380     2469      +89     
  Misses         74       74              
Impacted Files Coverage Δ
...ellyfish-transaction/src/buffer/buffer_composer.ts 99.48% <100.00%> (+0.01%) ⬆️
...ages/jellyfish-transaction/src/script/defi/dftx.ts 97.36% <100.00%> (+0.18%) ⬆️
...jellyfish-transaction/src/script/defi/dftx_pool.ts 100.00% <100.00%> (ø)
...ckages/jellyfish-transaction/src/script/mapping.ts 96.59% <100.00%> (+0.20%) ⬆️
packages/jellyfish-api-core/src/category/wallet.ts 100.00% <0.00%> (ø)
...h-transaction-builder/src/txn/txn_builder_error.ts 100.00% <0.00%> (ø)
...transaction-builder/src/txn/txn_builder_oracles.ts 100.00% <0.00%> (ø)
...ish-transaction/src/script/defi/dftx_governance.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31ec934...fdd5346. Read the comment docs.

@fuxingloh fuxingloh mentioned this pull request May 30, 2021
17 tasks
@netlify
Copy link

netlify bot commented May 31, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 34ad5bc

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60b4441a4cd714000723e20a

😎 Browse the preview: https://deploy-preview-314--jellyfish-defi.netlify.app

@canonbrother canonbrother marked this pull request as ready for review May 31, 2021 02:25
@canonbrother canonbrother marked this pull request as draft May 31, 2021 03:47
@canonbrother canonbrother marked this pull request as ready for review May 31, 2021 07:14
Copy link
Contributor

@fuxingloh fuxingloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment about type coercion, maybe should not do it?

@fuxingloh fuxingloh enabled auto-merge (squash) June 1, 2021 02:48
@fuxingloh fuxingloh requested a review from monstrobishi June 1, 2021 05:06
@fuxingloh fuxingloh merged commit 69e7f9c into main Jun 1, 2021
@fuxingloh fuxingloh deleted the canonbrother/dftx-update-poolpair branch June 1, 2021 09:53
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
* Bump @defichain/jellyfish dependencies

* fixed package-lock.json

Co-authored-by: Fuxing Loh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants