txn-builder: remove-oracle
#307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into monstrobishi/appoint-oracle-tx-builder
…robishi/appoint-oracle-tx-builder
…robishi/appoint-oracle-tx-builder
* getBlockStats, getBestBlockHash RCP implementation * Fixed and implemented requested changes. * Fixed requested changes * Minor fixes * Changed assertion to toStricEquals, additional test for getblockstats * Update packages/jellyfish-api-core/src/category/blockchain.ts Co-authored-by: Fuxing Loh <[email protected]> * Update packages/jellyfish-api-core/__tests__/category/blockchain.test.ts Co-authored-by: Fuxing Loh <[email protected]> * Update packages/jellyfish-api-core/src/category/blockchain.ts Co-authored-by: Fuxing Loh <[email protected]> * Additional test cases for getBlockStats * Minor fixes * Update blockchain.md * Minor fixes * Update blockchain.md Co-authored-by: Fuxing Loh <[email protected]>
monstrobishi
requested review from
canonbrother,
fuxingloh,
ivan-zynesis,
jingyi2811 and
thedoublejay
as code owners
…robishi/remove-oracle-tx-builder
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 96.98% 96.98%
=======================================
Files 90 90
Lines 2454 2456 +2
Branches 312 312
=======================================
+ Hits 2380 2382 +2
Misses 74 74
Continue to review full report at Codecov.
|
fuxingloh
suggested changes
May 28, 2021
packages/jellyfish-transaction-builder/__tests__/txn/txn_builder_remove_oracle.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-transaction-builder/__tests__/txn/txn_builder_remove_oracle.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-transaction-builder/__tests__/txn/txn_builder_remove_oracle.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-transaction-builder/__tests__/txn/txn_builder_remove_oracle.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-transaction-builder/__tests__/txn/txn_builder_remove_oracle.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-transaction-builder/__tests__/txn/txn_builder_remove_oracle.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Fuxing Loh <[email protected]>
fuxingloh
approved these changes
May 28, 2021
canonbrother
approved these changes
May 28, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Adds remove oracle to transaction builder
Which issue(s) does this PR fixes?:
Fixes #244
Additional comments?: