Add blockchain.getBlockStats, blockchain.getBestBlockHash RPC
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: 26eeb71 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60af24f3a777e20007e006d6 😎 Browse the preview: https://deploy-preview-256--jellyfish-defi.netlify.app |
siradji
changed the title
|
@siradji: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository. |
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #256 +/- ##
==========================================
+ Coverage 96.49% 96.92% +0.42%
==========================================
Files 85 89 +4
Lines 2228 2408 +180
Branches 287 308 +21
==========================================
+ Hits 2150 2334 +184
+ Misses 78 74 -4
Continue to review full report at Codecov.
|
fuxingloh
suggested changes
May 19, 2021
packages/jellyfish-api-core/__tests__/category/blockchain.test.ts
Outdated
Show resolved
Hide resolved
fuxingloh
suggested changes
May 19, 2021
packages/jellyfish-api-core/__tests__/category/blockchain.test.ts
Outdated
Show resolved
Hide resolved
canonbrother
requested changes
May 19, 2021
packages/jellyfish-api-core/__tests__/category/blockchain.test.ts
Outdated
Show resolved
Hide resolved
siradji
force-pushed
the
siradji/getblockstats
branch
2 times, most recently
from
06c0c98 to
2f1e637
Compare
siradji
force-pushed
the
siradji/getblockstats
branch
from
49e2a3f to
2df1419
Compare
|
Code Climate has analyzed commit 26eeb71 and detected 0 issues on this pull request. View more on Code Climate. |
fuxingloh
changed the title
blockchain.getBlockStats, blockchain.getBestBlockHash RPC
jingyi2811
reviewed
May 25, 2021
packages/jellyfish-api-core/__tests__/category/blockchain.test.ts
Outdated
Show resolved
Hide resolved
fuxingloh
reviewed
May 26, 2021
fuxingloh
approved these changes
May 26, 2021
auto-merge was automatically disabled
May 26, 2021 14:47
Pull request was converted to draft
canonbrother
approved these changes
May 27, 2021
jingyi2811
approved these changes
May 27, 2021
fuxingloh
approved these changes
May 27, 2021
thedoublejay
approved these changes
May 27, 2021
monstrobishi
pushed a commit
that referenced
this pull request
May 27, 2021
* getBlockStats, getBestBlockHash RCP implementation * Fixed and implemented requested changes. * Fixed requested changes * Minor fixes * Changed assertion to toStricEquals, additional test for getblockstats * Update packages/jellyfish-api-core/src/category/blockchain.ts Co-authored-by: Fuxing Loh <[email protected]> * Update packages/jellyfish-api-core/__tests__/category/blockchain.test.ts Co-authored-by: Fuxing Loh <[email protected]> * Update packages/jellyfish-api-core/src/category/blockchain.ts Co-authored-by: Fuxing Loh <[email protected]> * Additional test cases for getBlockStats * Minor fixes * Update blockchain.md * Minor fixes * Update blockchain.md Co-authored-by: Fuxing Loh <[email protected]>
fuxingloh
added a commit
that referenced
this pull request
May 28, 2021
* updated to latest image * Updated to 1.7.0 rc5 tag * Fix mining test * Initial setup * Updated test * Updated EunosHeight in RegTest container * Added override pair * Tests passing, added docs * Increased code coverage * Add `blockchain.getBlockStats`, `blockchain.getBestBlockHash` RPC (#256) * getBlockStats, getBestBlockHash RCP implementation * Fixed and implemented requested changes. * Fixed requested changes * Minor fixes * Changed assertion to toStricEquals, additional test for getblockstats * Update packages/jellyfish-api-core/src/category/blockchain.ts Co-authored-by: Fuxing Loh <[email protected]> * Update packages/jellyfish-api-core/__tests__/category/blockchain.test.ts Co-authored-by: Fuxing Loh <[email protected]> * Update packages/jellyfish-api-core/src/category/blockchain.ts Co-authored-by: Fuxing Loh <[email protected]> * Additional test cases for getBlockStats * Minor fixes * Update blockchain.md * Minor fixes * Update blockchain.md Co-authored-by: Fuxing Loh <[email protected]> * Added remove oracle and tests * Fix test * Tidy test * Apply suggestions from code review Co-authored-by: Fuxing Loh <[email protected]> Co-authored-by: Fuxing Loh <[email protected]> Co-authored-by: Suraj Auwal <[email protected]> Co-authored-by: Fuxing Loh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind Feature
What this PR does / why we need it:
implementation of RCP #48
Which issue(s) does this PR fixes?:
Fixes #
Additional comments?: