Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DfTx TokenUpdate, TokenUpdateAny #300

Merged
merged 6 commits into from
May 28, 2021
Merged

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented May 27, 2021

What kind of PR is this?:

/kind feature

Which issue(s) does this PR fixes?:

Fixes part of #108

@codeclimate
Copy link

codeclimate bot commented May 27, 2021

Code Climate has analyzed commit 03f3713 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 2

View more on Code Climate.

@netlify
Copy link

netlify bot commented May 27, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 6399a11

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60af3877c787fe0008a1e973

😎 Browse the preview: https://deploy-preview-300--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented May 27, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.51 KB (0%) 391 ms (0%) 171 ms (-4.22% 🔽) 562 ms

@canonbrother canonbrother marked this pull request as ready for review May 27, 2021 06:45
@BirthdayResearch BirthdayResearch deleted a comment from codeclimate bot May 27, 2021
Copy link
Contributor

@fuxingloh fuxingloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor changes

@fuxingloh
Copy link
Contributor

There is failing test

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #300 (5b51c95) into main (159c913) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   96.75%   96.96%   +0.21%     
==========================================
  Files          88       89       +1     
  Lines        2342     2440      +98     
  Branches      299      311      +12     
==========================================
+ Hits         2266     2366     +100     
+ Misses         76       74       -2     
Impacted Files Coverage Δ
...ages/jellyfish-transaction/src/script/defi/dftx.ts 97.18% <100.00%> (+0.40%) ⬆️
...ellyfish-transaction/src/script/defi/dftx_token.ts 100.00% <100.00%> (ø)
...ckages/jellyfish-transaction/src/script/mapping.ts 96.38% <100.00%> (+0.43%) ⬆️
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <0.00%> (ø)
...ages/jellyfish-api-core/src/category/blockchain.ts 100.00% <0.00%> (ø)
...tcontainers/src/chains/reg_test_container/index.ts 100.00% <0.00%> (ø)
...ish-transaction/src/script/defi/dftx_masternode.ts 100.00% <0.00%> (ø)
...ellyfish-transaction/src/buffer/buffer_composer.ts 99.46% <0.00%> (+0.03%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159c913...5b51c95. Read the comment docs.

@fuxingloh fuxingloh mentioned this pull request May 27, 2021
17 tasks
@fuxingloh fuxingloh self-requested a review May 28, 2021 05:34
@fuxingloh fuxingloh enabled auto-merge (squash) May 28, 2021 05:34
@fuxingloh fuxingloh merged commit 31ec934 into main May 28, 2021
@fuxingloh fuxingloh deleted the canonbrother/dftx-update-token branch May 28, 2021 07:18
eli-lim pushed a commit that referenced this pull request Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants