Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DfTx TokenCreate #208

Merged
merged 13 commits into from
May 25, 2021
Merged

Add DfTx TokenCreate #208

merged 13 commits into from
May 25, 2021

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented May 12, 2021

What kind of PR is this?:

/kind feature

Which issue(s) does this PR fixes?:

Fixes part of #108

@github-actions
Copy link

github-actions bot commented May 12, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.09 KB (0%) 382 ms (0%) 166 ms (+1.52% 🔺) 548 ms

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #208 (daa2138) into main (454cd1f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head daa2138 differs from pull request most recent head 9aeb58c. Consider uploading reports for the commit 9aeb58c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   96.50%   96.55%   +0.04%     
==========================================
  Files          85       86       +1     
  Lines        2230     2262      +32     
  Branches      287      289       +2     
==========================================
+ Hits         2152     2184      +32     
  Misses         78       78              
Impacted Files Coverage Δ
...jellyfish-transaction/src/buffer/buffer_bitmask.ts 100.00% <100.00%> (ø)
...ellyfish-transaction/src/buffer/buffer_composer.ts 99.42% <100.00%> (+0.04%) ⬆️
...ages/jellyfish-transaction/src/script/defi/dftx.ts 96.22% <100.00%> (+0.14%) ⬆️
...ellyfish-transaction/src/script/defi/dftx_token.ts 100.00% <100.00%> (ø)
...ckages/jellyfish-transaction/src/script/mapping.ts 95.38% <100.00%> (+0.14%) ⬆️
...ages/jellyfish-api-core/src/category/blockchain.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd323e5...9aeb58c. Read the comment docs.

@canonbrother

This comment has been minimized.

@fuxingloh fuxingloh mentioned this pull request May 17, 2021
17 tasks
@codeclimate
Copy link

codeclimate bot commented May 20, 2021

Code Climate has analyzed commit 9aeb58c and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented May 20, 2021

Deploy Preview for jellyfish-defi ready!

Built with commit 9aeb58c

https://deploy-preview-208--jellyfish-defi.netlify.app

@canonbrother canonbrother force-pushed the canonbrother/dftx-create-token branch from 70972ee to 0a7b7f7 Compare May 20, 2021 17:05
@canonbrother canonbrother marked this pull request as ready for review May 21, 2021 03:57
@canonbrother

This comment has been minimized.

@canonbrother canonbrother marked this pull request as draft May 21, 2021 04:37
@canonbrother canonbrother marked this pull request as ready for review May 24, 2021 01:37
@fuxingloh fuxingloh marked this pull request as draft May 24, 2021 04:43
@canonbrother canonbrother marked this pull request as ready for review May 24, 2021 07:42
fuxingloh
fuxingloh previously approved these changes May 24, 2021
@fuxingloh fuxingloh enabled auto-merge (squash) May 24, 2021 11:33
@fuxingloh fuxingloh changed the title added Dftx TokenCreate added Dftx TokenCreate May 24, 2021
@fuxingloh fuxingloh changed the title added Dftx TokenCreate Add Dftx TokenCreate May 24, 2021
@fuxingloh fuxingloh requested a review from monstrobishi May 25, 2021 02:48
@fuxingloh fuxingloh merged commit 4a29027 into main May 25, 2021
@fuxingloh fuxingloh deleted the canonbrother/dftx-create-token branch May 25, 2021 03:32
@fuxingloh fuxingloh changed the title Add Dftx TokenCreate Add DfTx TokenCreate May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants