Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2.11): DeFiChain Node v2.11 Release #1751

Merged
merged 12 commits into from
Sep 19, 2022
Merged

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented Sep 13, 2022

What this PR does / why we need it:

Support for DeFiChain Node v2.11.1 via custom branch defi/defichain:HEAD-02ef6a1b3 due to plenty of breaking issues.

  • Corrected Error String to was updated
  • Updated test that was "should not ..." and has become "should ..."

Issue opened that need to be addressed:

@codeclimate
Copy link

codeclimate bot commented Sep 13, 2022

Code Climate has analyzed commit 744e3d8 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 744e3d8
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/6327f710b076630007381ab3
😎 Deploy Preview https://deploy-preview-1751--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 61.86% // Head: 93.53% // Increases project coverage by +31.66% 🎉

Coverage data is based on head (744e3d8) compared to base (856da19).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1751       +/-   ##
===========================================
+ Coverage   61.86%   93.53%   +31.66%     
===========================================
  Files         289      361       +72     
  Lines        9171    10416     +1245     
  Branches     1185     1304      +119     
===========================================
+ Hits         5674     9743     +4069     
+ Misses       3287      642     -2645     
+ Partials      210       31      -179     
Impacted Files Coverage Δ
...ontainers/src/containers/RegTestContainer/index.ts 100.00% <ø> (+12.50%) ⬆️
...es/testcontainers/src/containers/DeFiDContainer.ts 91.11% <100.00%> (+7.77%) ⬆️
...core/src/saga/AddressParser/dftx/AccountToUtxos.ts 62.50% <0.00%> (-37.50%) ⬇️
...ges/rich-list-core/src/saga/AddressParser/index.ts 92.85% <0.00%> (-3.58%) ⬇️
apps/playground-api/src/setups/setup.gov.ts 100.00% <0.00%> (ø)
apps/playground-api/src/setups/setup.oracle.ts 96.15% <0.00%> (ø)
...s/playground-api-client/src/PlaygroundApiClient.ts 100.00% <0.00%> (ø)
...ckages/ocean-api-client/src/errors/ApiException.ts 100.00% <0.00%> (ø)
apps/playground-api/src/setups/setup.utxo.ts 100.00% <0.00%> (ø)
apps/playground-api/src/Fastify.ts 100.00% <0.00%> (ø)
... and 250 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 13, 2022

Docker build preview for jellyfish/apps is ready!

Built with commit ef7a60f

  • ghcr.io/jellyfishsdk/legacy-api:pr-1751
  • ghcr.io/jellyfishsdk/ocean-api:pr-1751
  • ghcr.io/jellyfishsdk/playground-api:pr-1751
  • ghcr.io/jellyfishsdk/status-api:pr-1751
  • ghcr.io/jellyfishsdk/whale-api:pr-1751

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:ef7a60f9ab44018cc69298086c493079f5f9c8b1
  • ghcr.io/jellyfishsdk/ocean-api:ef7a60f9ab44018cc69298086c493079f5f9c8b1
  • ghcr.io/jellyfishsdk/playground-api:ef7a60f9ab44018cc69298086c493079f5f9c8b1
  • ghcr.io/jellyfishsdk/status-api:ef7a60f9ab44018cc69298086c493079f5f9c8b1
  • ghcr.io/jellyfishsdk/whale-api:ef7a60f9ab44018cc69298086c493079f5f9c8b1

@fuxingloh
Copy link
Contributor Author

@thedoublejay FYI on the recently added flags that should be reflected for playground deployment:

See 3f2d17c

@fuxingloh
Copy link
Contributor Author

too many breaking tests...

@fuxingloh fuxingloh merged commit c6a5a4f into main Sep 19, 2022
@fuxingloh fuxingloh deleted the fuxingloh/ain/2-11-0 branch September 19, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants