Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use defid v2.11.1 container and fix all breaking regression change from upstream. #1764

Closed
fuxingloh opened this issue Sep 19, 2022 · 4 comments
Closed

Use defid v2.11.1 container and fix all breaking regression change from upstream. #1764

fuxingloh opened this issue Sep 19, 2022 · 4 comments
Assignees
@fuxingloh
Labels
area/packages kind/bug Something isn't working priority/important-soon Will be important soon triage/accepted Triage has been accepted

Comments

@fuxingloh
Copy link
Contributor

For feat(v2.11): DeFiChain Node v2.11 Release #1751; support for DeFiChain Node v2.11.1 via custom branch defi/defichain:HEAD-02ef6a1b3 due to plenty of breaking issues.

It was a temporary measure to use the custom branch, however, fixes are required to address the regression issue and migrate to 2.11.1. However, there are over 500 breaking tests, we need a better way to address it.

/area packages
/proprity important-soon
@fuxingloh fuxingloh added the kind/bug Something isn't working label Sep 19, 2022
@fuxingloh fuxingloh mentioned this issue Sep 19, 2022
Merged
@jellyfishsdk-bot jellyfishsdk-bot added the needs/triage Waiting for triage to be accepted label Sep 19, 2022
@jellyfishsdk-bot
Copy link
Contributor

@fuxingloh: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the JellyfishSDK developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

fuxingloh added a commit that referenced this issue Sep 19, 2022
@fuxingloh
feat(v2.11): DeFiChain Node v2.11 Release (#1751)
c6a5a4f 
<!--  Thanks for sending a pull request! -->

#### What this PR does / why we need it:

Support for DeFiChain Node `v2.11.1` via custom branch
`defi/defichain:HEAD-02ef6a1b3` due to plenty of breaking issues.

- Corrected Error String to was updated
- Updated test that was "should not ..." and has become "should ..."

Issue opened that need to be addressed:
- #1763
- #1764
@fuxingloh fuxingloh mentioned this issue Sep 22, 2022
Closed
7 tasks
@fuxingloh
Copy link
Contributor Author

/triage accepted

@jellyfishsdk-bot jellyfishsdk-bot added triage/accepted Triage has been accepted and removed needs/triage Waiting for triage to be accepted labels Sep 22, 2022
@fuxingloh
Copy link
Contributor Author

/priority important-soon
/assign @fuxingloh

@jellyfishsdk-bot jellyfishsdk-bot added the priority/important-soon Will be important soon label Oct 7, 2022
@fuxingloh
Copy link
Contributor Author

Open an issue upstream instead of fixing it here #1764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fuxingloh fuxingloh

Labels
area/packages kind/bug Something isn't working priority/important-soon Will be important soon triage/accepted Triage has been accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fuxingloh @jellyfishsdk-bot