Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added DfTx PoolRemoveLiquidity #146

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented Apr 20, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Added DfTx PoolRemoveLiquidity Buffer composing

  • Need more test fixtures

@fuxingloh fuxingloh added this to the Jellyfish Wallet milestone Apr 20, 2021
@fuxingloh fuxingloh mentioned this pull request Apr 20, 2021
17 tasks
@github-actions
Copy link

github-actions bot commented Apr 20, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 17.96 KB (0%) 360 ms (0%) 149 ms (-3.9% 🔽) 509 ms

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #146 (439613b) into main (3d829db) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   94.97%   95.10%   +0.12%     
==========================================
  Files          44       44              
  Lines         975     1000      +25     
  Branches      115      115              
==========================================
+ Hits          926      951      +25     
  Misses         47       47              
  Partials        2        2              
Impacted Files Coverage Δ
...ages/jellyfish-transaction/src/script/defi/dftx.ts 92.00% <100.00%> (+0.69%) ⬆️
...jellyfish-transaction/src/script/defi/dftx_pool.ts 100.00% <100.00%> (ø)
...ckages/jellyfish-transaction/src/script/mapping.ts 96.29% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6319dd...439613b. Read the comment docs.

@fuxingloh fuxingloh marked this pull request as ready for review April 20, 2021 08:00
@fuxingloh fuxingloh merged commit c8a8431 into main Apr 20, 2021
@fuxingloh fuxingloh deleted the fuxingloh/dftx-pool-remove-liquidity branch April 20, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants