Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-core to use named export instead of * #124

Closed
wants to merge 1 commit into from

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented Apr 14, 2021

What kind of PR is this?:

/kind refactor

What this PR does / why we need it:

To prevent conflicts due to the massive amount of data to type, export should be named.

/cc @canonbrother might cause your pending PR to break, hence this should merge after #112 and then this PR should be updated.

@fuxingloh fuxingloh added this to the Jellyfish Documentation milestone Apr 14, 2021
@netlify
Copy link

netlify bot commented Apr 14, 2021

Deploy preview for jellyfish-defi canceled.

Built with commit e0659e0

https://app.netlify.com/sites/jellyfish-defi/deploys/607720c6f13020000803f810

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 16.68 KB (+0.78% 🔺) 334 ms (+0.78% 🔺) 165 ms (+17.1% 🔺) 499 ms

@fuxingloh
Copy link
Contributor Author

Closes in favour of #130

@fuxingloh fuxingloh closed this Apr 17, 2021
@fuxingloh fuxingloh deleted the fuxingloh/export-conflict branch April 17, 2021 06:59
eli-lim pushed a commit that referenced this pull request Mar 27, 2022
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor Non feature refactor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants