blockchain.getRawMempool, wallet.getNewAddress, wallet.getAddressInfo, wallet.validateAddress, wallet.listAddressGroupings, wallet.getWalletInfo, wallet.setWalletFlag, wallet.sendToAddress, wallet.createWallet #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for jellyfish-defi ready! Built with commit 7a45c00 |
size-limit report 📦
|
canonbrother
changed the title
canonbrother
requested review from
fullstackninja864,
fuxingloh and
thedoublejay
as code owners
Codecov Report
@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 94.46% 94.70% +0.24%
==========================================
Files 40 40
Lines 831 888 +57
Branches 95 108 +13
==========================================
+ Hits 785 841 +56
- Misses 44 45 +1
Partials 2 2
Continue to review full report at Codecov.
|
fuxingloh
suggested changes
Apr 14, 2021
fuxingloh
reviewed
Apr 14, 2021
fuxingloh
approved these changes
Apr 19, 2021
Comment on lines
+28
to
+30
| * @param {CreateRawTxOptions=} options | ||
| * @param {number=} options.locktime Non-0 value also locktime-activates inputs | ||
| * @param {boolean=} options.replaceable Marks this transaction as BIP125-replaceable |
There was a problem hiding this comment.
We could use this syntax instead, we can standard this in the future
* @param {number} [options.locktime=0] Non-0 value...
|
|
||
| ```ts title="client.wallet.setWalletFlag()" | ||
| interface wallet { | ||
| setWalletFlag (flag: WalletFlag, value: boolean = true): Promise<WalletFlagResult> |
There was a problem hiding this comment.
WalletFlag enum missing in docs.
|
|
||
| ```ts title="client.wallet.getNewAddress()" | ||
| interface wallet { | ||
| getNewAddress (label: string = '', addressType = AddressType.BECH32): Promise<string> |
There was a problem hiding this comment.
AddressType enum missing in docs
Comment on lines
+312
to
+313
| ['witness_version']: number | ||
| ['witness_program']: string |
There was a problem hiding this comment.
witness_version: number
witness_program: string
Comment on lines
+38
to
+42
| return await waitForExpect(async () => { | ||
| const aliceAddress = await client.wallet.getNewAddress('alice') | ||
|
|
||
| expect(typeof aliceAddress).toBe('string') | ||
| }) |
There was a problem hiding this comment.
I wonder why you wrap everything in waitForExpect?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Implemented type for RPC: #48