-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
factor in slippage for poolswap calculation #433
Conversation
Code Climate has analyzed commit 0790d0c and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 87.79% 87.86% +0.07%
==========================================
Files 103 103
Lines 1663 1673 +10
Branches 269 268 -1
==========================================
+ Hits 1460 1470 +10
Misses 202 202
Partials 1 1
Continue to review full report at Codecov.
|
✔️ Deploy Preview for defi-wallet ready! 🔨 Explore the source changes: 0790d0c 🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/610baae0bd07ab0007ac23b5 😎 Browse the preview: https://deploy-preview-433--defi-wallet.netlify.app/ |
Build preview for DeFi Wallet is ready! Built with commit f8b9bac https://expo.io/@defichain/wallet?release-channel=pr-preview-433 |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the ux is following testpoolswap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX wise we should also display something about slippage and worst-case scenario
U-Zyn
@thedoublejay to create an issue to track the above
What kind of PR is this?:
/kind fix
What this PR does / why we need it:
Factor in slippage for pool swap to have more accurate results. Updated e2e to check if the poolswap amount is same
Which issue(s) does this PR fixes?:
Fixes #341
Additional comments?: