Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor in slippage for poolswap calculation #433

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

thedoublejay
Copy link
Contributor

@thedoublejay thedoublejay commented Aug 5, 2021

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

Factor in slippage for pool swap to have more accurate results. Updated e2e to check if the poolswap amount is same

Which issue(s) does this PR fixes?:

Fixes #341

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Aug 5, 2021

Code Climate has analyzed commit 0790d0c and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #433 (0790d0c) into main (c32eae0) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   87.79%   87.86%   +0.07%     
==========================================
  Files         103      103              
  Lines        1663     1673      +10     
  Branches      269      268       -1     
==========================================
+ Hits         1460     1470      +10     
  Misses        202      202              
  Partials        1        1              
Impacted Files Coverage Δ
...pNavigator/screens/Dex/PoolSwap/PoolSwapScreen.tsx 95.74% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32eae0...0790d0c. Read the comment docs.

@fuxingloh fuxingloh requested a review from canonbrother August 5, 2021 07:20
@netlify
Copy link

netlify bot commented Aug 5, 2021

✔️ Deploy Preview for defi-wallet ready!

🔨 Explore the source changes: 0790d0c

🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/610baae0bd07ab0007ac23b5

😎 Browse the preview: https://deploy-preview-433--defi-wallet.netlify.app/

@defichain-bot
Copy link
Contributor

defichain-bot commented Aug 5, 2021

Build preview for DeFi Wallet is ready!

Built with commit f8b9bac

https://expo.io/@defichain/wallet?release-channel=pr-preview-433

@cypress
Copy link

cypress bot commented Aug 5, 2021



Test summary

127 0 0 0


Run details

Project wallet
Status Passed
Commit f8b9bac ℹ️
Started Aug 5, 2021 9:14 AM
Ended Aug 5, 2021 9:29 AM
Duration 15:14 💡
OS Linux Ubuntu - 20.04
Browser Chrome 92

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@canonbrother canonbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the ux is following testpoolswap

@thedoublejay thedoublejay enabled auto-merge (squash) August 5, 2021 14:18
Copy link
Contributor

@fuxingloh fuxingloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX wise we should also display something about slippage and worst-case scenario
U-Zyn

@thedoublejay to create an issue to track the above

@thedoublejay thedoublejay merged commit 924c438 into main Aug 5, 2021
@thedoublejay thedoublejay deleted the thedoublejay/poolswap branch August 5, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

review poolswap calculations
4 participants