Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review poolswap calculations #341

Closed
thedoublejay opened this issue Jul 25, 2021 · 2 comments · Fixed by #433
Closed

review poolswap calculations #341

thedoublejay opened this issue Jul 25, 2021 · 2 comments · Fixed by #433
Labels
kind/bug Something isn't working needs/area Needs area label(s) needs/triage Waiting for triage to be accepted

Comments

@thedoublejay
Copy link
Contributor

What happened:

Revisit calculations for poolswap. Currently, the values are less than the received amount. In the desktop app, we're using testpoolswap for the update prices. Might be different in the mobile wallet but worth checking.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

@thedoublejay thedoublejay added the kind/bug Something isn't working label Jul 25, 2021
@defichain-bot defichain-bot added the needs/triage Waiting for triage to be accepted label Jul 25, 2021
@defichain-bot
Copy link
Contributor

@thedoublejay: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@defichain-bot defichain-bot added the needs/area Needs area label(s) label Jul 25, 2021
@defichain-bot
Copy link
Contributor

@thedoublejay: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working needs/area Needs area label(s) needs/triage Waiting for triage to be accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants