Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
When fixing the issue with new cljfmt using a new configuration format, I forgot about how we are using an old cljfmt for the Format and Align Current Form command/mode. That cljfmt of course uses the old configuration format. It all gets quite confusing already before this fact, with the backward compatibility ket
:legacy/merge-indents?
key... I tried to ease the extra confusion a bit by::legacy/merge-indents?
key, andThe case we don't handle (which i am not sure we ever handled) is align-formatting using the legacy format and the
^:replace
metadata. That can only be achieved by using the new configuration format (and not specifying legacy merge). Haha, I don't know if this is possible to follow, but anyway, the (hopefully small) slice of the user base, that want aligned formatting, and that can't use the new configuration format, won't be able to.I don't think I can express how much I long for this PR to be merged into cljfmt:
😄
Also in this PR is an update of Calva's own cljfmt.edn config to use the new configuration format, as well as some fixes to the formatting that had become weird because we had forgotten about this. Oh, the irony...
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.[ ] Added to or updated docs in this branch, if appropriatenpm run prettier-format
)npm run eslint
before creating your PR, or runnpm run eslint-watch
to eslint as you go).Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik