Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between regular formatting and formatting with alignment #2289

Closed
isacjunior opened this issue Aug 18, 2023 · 1 comment
Closed
Labels
bug Something isn't working configuration formatting regression Regression error

Comments

@isacjunior
Copy link
Contributor

isacjunior commented Aug 18, 2023

I use clojure-lsp and I noticed a difference between commands.
Calva Format: Format Current Form - Works perfectly
Calva Format: Format and Align Current Form - Doesn't format using cljfmt from clojure-lsp config

Useful information
lsp.config.edn contains the :legacy/merge-indents? true

Calva version used: v2.0.386
clojure-lsp version used: 2023.08.06-00.28.06
clj-kondo version used: 2023.07.14-SNAPSHOT
@PEZ PEZ added bug Something isn't working formatting regression Regression error configuration labels Aug 18, 2023
@PEZ PEZ changed the title Difference between format commands Difference between regular formatting and formatting with alignment Aug 18, 2023
@PEZ
Copy link
Collaborator

PEZ commented Aug 18, 2023

Thanks! It's a regression since we moved to latest cljfmt for the regular formatting, where the configuration semantics has been changed. The alignment formatting is still using a very old version of cljfmt and thus the old configuration. I forgot about this when upgrading. Will fix!

FYI, it probably has nothing to do with clojure-lsp.

@PEZ PEZ mentioned this issue Aug 19, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working configuration formatting regression Regression error
Projects
None yet
Development

No branches or pull requests

2 participants