Major performance improvement achieved through fixing clippy warnings

[pyros82]

Most notable performance problem was the code used Result::ok_or() instead of Result::ok_or_else(||), thus causing the creation of the error strings / objects regardless of whether there was an error or not. This reduced Parsed::from_value() times about 50 fold.

I then followed to fix all clippy warnings, and to add a cargo clippy step to the ci.yaml build section, so that we ensure clippy is happy in the future too.

[vmalloc]

@jstewmon any chance you can give this one a quick look and perhaps merge it into a new version? This is a very significant performance gain compared to the current stable version, with little to no risk IMO

[gquittet]

I tested the pull request with some examples and everything is running fine.
So looks good to me! 👍
Unfortunately I haven't the rights to merge this work.
Can you do it @jstewmon or @mplanchard when you have time? 🙏
Thank you ! 🤟

[jstewmon]

Hi, thank you for your interest in contributing. ❤️ Sorry for the slow response; we don't have much capacity to service this project currently.

Thank you for making a few separate commits - I was able pick the ok_or_else changes while doing some work in this repo today. 🙌

I'd be interested in accepting the clippy-related changes if you can parcel them out into a couple of separate PRs, so that I can quickly verify the ones that are automatic fixes and then more carefully review the hand crafted ones. I'd also like to isolate whatever change necessitated the library changes and have a more detailed explanation of why the library change is needed.

[pyros82]

Hi, I also don't have the capacity for redoing the PR as even more separate commits. I believe it would be faster for you to run clippy the next time you do work on the library, than for me to organize it your way. The ok_or_else was the critical PR, as it sped up the library a hundred fold. The rest, I did out of curtesy to help keeping the library up to date with modern Rust. It's ok by me if you leave it unmaintained if it's ok by you. Your call of course. Cheers, Avishay

…

On Tue, Jul 2, 2024, 01:58 Jonathan Stewmon ***@***.***> wrote: Hi, thank you for your interest in contributing. ❤️ Sorry for the slow response; we don't have much capacity to service this project currently. Thank you for making a few separate commits - I was able pick the ok_or_else changes while doing some work in this repo today. 🙌 I'd be interested in accepting the clippy-related changes if you can parcel them out into a couple of separate PRs, so that I can quickly verify the ones that are automatic fixes and then more carefully review the hand crafted ones. I'd also like to isolate whatever change necessitated the library changes and have a more detailed explanation of why the library change is needed. — Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEAXZM5MHL3HCYGIVRYSHKLZKHNJLAVCNFSM6AAAAABGCDYY2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBRGMZDANJVGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>