Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust Implementation #46

Open
codetiger opened this issue Nov 20, 2024 · 2 comments
Open

Rust Implementation #46

codetiger opened this issue Nov 20, 2024 · 2 comments

Comments

@codetiger
Copy link

I couldn’t find a good Rust implementation that is stable and maintained so I’ve created one. Please share feedback, am interested in maintaining this repo for long term. Am using it in other projects.

https://github.com/Open-Payments/datalogic-rs

@TotalTechGeek
Copy link

TotalTechGeek commented Nov 22, 2024

Oh neat! Awesome work!

Just curious (and I figure other folks might ask) -- Are you aware of any differences from https://github.com/Bestowinc/json-logic-rs?

Adding a stray thought here:

It might be cool to create a JSON Logic Benchmark Repo that compares compatibility and performance of different JSON Logic runners.

I might take that on as a weekend project...

@codetiger
Copy link
Author

Thanks for your feedback.

Let me add the answer to this question on the README somewhere soon. The short answer is, yes I did consider using the repos (https://github.com/Bestowinc/json-logic-rs, https://github.com/mplanchard/json-logic-plus, and others) for my project, but they are mostly unmaintained and had lot of signs that there is no intention to accept PRs or future scope. You can see the links for example (Bestowinc/json-logic-rs#30 and Bestowinc/json-logic-rs#35). I also gave up on considering forking and maintaining it as I had some basic design changes.

Finally I decided to build something myself and It didn't take much time. As this is one of the core framework for my whole product, am considering putting good time on weekly basis to keep maintaining it.

As performance is the key focus in my case, the idea of creating a performance comparison repo makes a lot of sense. Once I've enough JSONLogic implemented for real world use cases, I'll consider building the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants