Iron out type-checking and formatting #138
Conversation
Samuel-Therrien-Beslogic
force-pushed
the
iron-out-type-checking-and-linting
branch
from
8f8111e to
a7d19dd
Compare
canopeum_backend/canopeum_backend/management/commands/initialize_database.py
Outdated
Show resolved
Hide resolved
| @classmethod | ||
| def from_string(cls, value: str): |
There was a problem hiding this comment.
CC @NicolasDontigny This is how you do a classmethod in Python (ie: a method you call on the class itself, this is technically different than a static method, but this would be a static method in other languages)
| # Missing "id" in "Model" or some base "User" class? | ||
| if TYPE_CHECKING: | ||
| id: int |
There was a problem hiding this comment.
Not sure if missing from upstream type stubs or if we're doing something specific to have an id on our user.
| # TODO: Are we sure about getlist ? | ||
| # If this is correct, consider raising an issue upstream | ||
| for tree_type_json in request.data.getlist("species"): # type:ignore[attr-defined] # pyright: ignore[reportAttributeAccessIssue] |
There was a problem hiding this comment.
@BesOlivierBouchard Since you added this. Can you validate whether this is valid code?
There was a problem hiding this comment.
From what I saw online, this is the way to retrieve a "list" from "data". Doing it with the get() or the data[] will not work properly.
| try: | ||
| post = Post.objects.get(pk=postId) | ||
| except Post.DoesNotExist: | ||
| return Response(status="sef") |
There was a problem hiding this comment.
I don't think "sef" status was intended? I went with HTTP_404_NOT_FOUND by combining the try-except
Samuel-Therrien-Beslogic
force-pushed
the
iron-out-type-checking-and-linting
branch
from
a7d19dd to
dd3cf97
Compare
Samuel-Therrien-Beslogic
force-pushed
the
iron-out-type-checking-and-linting
branch
from
dd3cf97 to
f49ebdf
Compare
…eleaf-canopeum into iron-out-type-checking-and-linting
…om/BesLogic/releaf-canopeum into iron-out-type-checking-and-linting
…to iron-out-type-checking-and-linting
for more information, see https://pre-commit.ci
…om/BesLogic/releaf-canopeum into iron-out-type-checking-and-linting
Please merge #144 first
djangorestframework-stubsRequestmodel to type therequestparam in our methods. This mainly allows to get ourUsermodel fromdrf-spectaculartype: ignorefrompyright: ignorecommentsserializers.SitePatchSerializerCross-referencing upstream issues:
@extend_schema_fieldtype hint does not accept simple python types tfranzel/drf-spectacular#1212