Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch.size is a TextField #139

Closed
Samuel-Therrien-Beslogic opened this issue May 8, 2024 · 2 comments
Closed

Batch.size is a TextField #139

Samuel-Therrien-Beslogic opened this issue May 8, 2024 · 2 comments

Comments

@Samuel-Therrien-Beslogic
Copy link
Contributor

Samuel-Therrien-Beslogic commented May 8, 2024 •
edited
Loading

In #138 (comment) I noticed that Batch.objects.create takes a size param of type str. This seems incorrect, let's update the DB model type to something number-based. (integer is fine)
Merged
Merged
@NicolasDontigny
Copy link
Collaborator

Seems to be fixed in the current code, can we close this issue?

@Samuel-Therrien-Beslogic
Copy link
Contributor Author

Fixed by #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Releaf Canopeum
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NicolasDontigny @Samuel-Therrien-Beslogic