Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general search should include results from family trees (Move Family Tree tab from main toolbar to results tabs) #280

Closed
TheGrandVizier opened this issue Feb 2, 2017 · 6 comments
Assignees

Comments

@TheGrandVizier
Copy link
Contributor

TheGrandVizier commented Feb 2, 2017

Add filters for:

  • First name
  • Last name (Exact, Starts with, Sounds like)
  • Sex (Male, Female, Nevermind)
  • Place of birth (Exact, Starts with, Sounds like)
  • Place of marriage (Exact, Starts with, Sounds like)
  • Place of death (Exact, Starts with, Sounds like)
  • Year of birth (Exact, +/-1 year, +/-2 years, +/-3 years)
  • Year of marriage (Exact, +/-1 year, +/-2 years, +/-3 years)
  • Year of death (Exact, +/-1 year, +/-2 years, +/-3 years)
  • Tree number

Invision link:
https://projects.invisionapp.com/d/main#/console/904587/214538825/preview

@TheGrandVizier TheGrandVizier added this to the v0.12 15FEB2017 Front milestone Feb 5, 2017
@TheGrandVizier
Copy link
Contributor Author

awaits backend

@OriHoch
Copy link
Contributor

OriHoch commented Mar 7, 2017

backend issue - Beit-Hatfutsot/dbs-back#33 - will add support for using the general search API to get results from family trees as well. On frontend it should simplify things as you will need to contact a single general search API for all search needs both general and family trees

@OriHoch
Copy link
Contributor

OriHoch commented Mar 7, 2017

following this logic of same search API used for family trees as well - frontend can start development
you can assume the search API will work the same way it does today just adding details about people (family trees)

@OriHoch OriHoch changed the title Move Family Tree tab from main toolbar to results tabs general search should include results from family trees (Move Family Tree tab from main toolbar to results tabs) Mar 7, 2017
@TheGrandVizier
Copy link
Contributor Author

Another backend issue for this related:
Beit-Hatfutsot/dbs-back#119

@OriHoch
Copy link
Contributor

OriHoch commented Apr 20, 2017

backend issue is done and deployed to test environment
API documentation is available here: http://devapi.dbs.bh.org.il/v1/docs#database-search-persons-advanced-search

Inna-r added a commit to Inna-r/dbs-front that referenced this issue May 4, 2017
Inna-r added a commit to Inna-r/dbs-front that referenced this issue May 15, 2017
Inna-r added a commit that referenced this issue May 15, 2017
…abs_#280

Move family tree tab to results tabs #280
@TheGrandVizier
Copy link
Contributor Author

TheGrandVizier commented May 21, 2017

This is done, but resulted in this:
#348
and
#375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants