Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general search API should support searching on family trees #33

Closed
TheGrandVizier opened this issue Oct 30, 2016 · 6 comments
Closed

general search API should support searching on family trees #33

TheGrandVizier opened this issue Oct 30, 2016 · 6 comments

Comments

@TheGrandVizier
Copy link

TheGrandVizier commented Oct 30, 2016

reproduction steps

  • open dbs website
  • click on search
  • search for "Moshe Cohen"
  • look at the backend network request
  • http://api.dbs.bh.org.il/v1/search?from_=0&q=Moshe+Cohen
    • note until frontend is changed to support persons, you have to add &with_persons=1 to get persons
  • check the response of this request
expected
  • response should include people named "Moshe Cohen" from the family trees
actual
  • response does not include people
  • currently family trees search uses a separate api

further filtering of the search results

expected
  • response contains only people results (AKA family trees results)

filtering even further using specific people fields

expected
  • all results which match the query and the additional filters (first_name, last_name etc..)
original issue description
_From @TheGrandVizier on October 9, 2016 11:41_

The general search should be... General, and include search results from family trees that are a good match.
This brings up questions of performance, as it basically doubles the amount of entries to search, or possibly even more than doubles.
I feel that consolidating these under general search with a result-filter tab of family trees is the way to go.

_Copied from original issue: Beit-Hatfutsot/dbs-front#214_
@TheGrandVizier
Copy link
Author

From @nuritgazit on October 27, 2016 9:17

@TheGrandVizier please move to backend

@OriHoch
Copy link
Contributor

OriHoch commented Mar 7, 2017

I'll do a technical design

@OriHoch OriHoch self-assigned this Mar 7, 2017
@OriHoch OriHoch changed the title Include Family trees in general search results general search API should support searching on family trees Mar 7, 2017
@OriHoch
Copy link
Contributor

OriHoch commented Mar 8, 2017

tech design done - updated in issue description, @daonb @Inna-r - please review

@TheGrandVizier
Copy link
Author

TheGrandVizier commented Apr 4, 2017

Supported filters:

  • First name
  • Last name (Exact, Starts with, Sounds like)
  • Sex (Male, Female, Nevermind)
  • Place of birth (Exact, Starts with, Sounds like)
  • Place of marriage (Exact, Starts with, Sounds like)
  • Place of death (Exact, Starts with, Sounds like)
  • Year of birth (Exact, +/-1 year, +/-2 years, +/-3 years)
  • Year of marriage (Exact, +/-1 year, +/-2 years, +/-3 years)
  • Year of death (Exact, +/-1 year, +/-2 years, +/-3 years)
  • Tree number

@OriHoch
Copy link
Contributor

OriHoch commented Apr 20, 2017

API documentation and list of supported fields for searching are available here:
http://devapi.dbs.bh.org.il/v1/docs#database-search-persons-advanced-search

@OriHoch
Copy link
Contributor

OriHoch commented Apr 20, 2017

deployed to test environment, see 0.12.3 release notes
@TheGrandVizier - ready for testing, you can see the API documentation for details
@Inna-r - you can start using the API on test environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants