This repository has been archived by the owner on Apr 20, 2021. It is now read-only.
increase JSON context DX #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Sep 11, 2018
|
Imo you should add some testcases |
|
@OskarStark I added some tests. It's not 100% tested, but it's better than before ;) |
sanpii
reviewed
Sep 11, 2018
| @@ -119,9 +128,15 @@ public function theJsonNodeShouldBeNull($node) | |||
| */ | |||
| public function theJsonNodeShouldNotBeNull($node) | |||
| { | |||
| $this->not(function () use ($node) { | |||
There was a problem hiding this comment.
Why you don’t use the not wrapper here?
There was a problem hiding this comment.
You are right, I could have.
The only "issue" I see is that all those function need to mock or instantiate Mink instance, and I'm not really confident with that for now.
If I change back to the not, I can not easily test the function.
(The error message is Mink instance has not been set on Mink context class. Have you enabled the Mink Extension?)
|
@sanpii up ? |
jdeniau
force-pushed
the
jd-feat-jsonDx
branch
from
7191bc6
to
200aa8a
Compare
fix ReflectionClass::getClass deprecated (php8)
This was referenced Nov 14, 2022
jdeniau
force-pushed
the
jd-feat-jsonDx
branch
from
5de51bb
to
1f986cd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error message, by telling with node is failing, the actual content and the expected value.