Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase JSON context DX #11

Merged
merged 6 commits into from
Dec 10, 2022
Merged

Conversation

jdeniau
Copy link

@jdeniau jdeniau commented Nov 14, 2022

Q A
Branch? main
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Thanks for the effort of forking behatch/contexts.

As behatch/context is unmaintained, I open the same PR I did there.

This pull request improves the error message, by telling which node is failing, the actual content and the expected value.

For the record, we use this at Mapado on my fork since 2018, and we find it way better with those messages.

Before (fail on first error, no hint about which line does fail):
image

With PR:
image

@jdeniau jdeniau mentioned this pull request Nov 14, 2022
@soyuka
Copy link
Owner

soyuka commented Dec 8, 2022

damn we should use a github actions ci if we really want to maintain this, did you run the tests?

@jdeniau
Copy link
Author

jdeniau commented Dec 8, 2022

Woops I did not saw that there was a Travis CI!

I just copied my PR on behatch here.

I will look at this maybe tomorrow!

@jdeniau
Copy link
Author

jdeniau commented Dec 9, 2022

@soyuka OK I understand your message now ! The main branch is failing too due to selenium.

This PR is a clone of Behatch#262 , where the CI did pass.
For the record, we use this since 2018 on Mapado code base (more than 100 000 lines of behat tests), so I'm pretty confidant about it 🫡

It seems that your fork did not change that much, so CI should pass 🤞 . If you want to merge this, and the CI does fail after fixing selenium, ping me and I will correct it if you want.

@soyuka soyuka merged commit e477dca into soyuka:main Dec 10, 2022
@soyuka
Copy link
Owner

soyuka commented Dec 10, 2022

I'll move the CI at some point

@soyuka
Copy link
Owner

soyuka commented Dec 10, 2022

actually: #2 haha need to make this work

@jdeniau jdeniau deleted the jd-feat-jsonDxSoyuka branch December 16, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants