Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved matcaffe #223

Merged
merged 10 commits into from
Apr 2, 2014
Merged

Improved matcaffe #223

merged 10 commits into from
Apr 2, 2014

Conversation

sguada
Copy link
Contributor

@sguada sguada commented Mar 18, 2014

This PR replaces #132 (see for the discussion)

Reshaped outputs of matcaffe forward to keep it parallel to the caffe representation.
Added get_weights from Ross to be able to get the weights from the network.
Added backward to matcaffe inspired by the pycaffe code (not tested yet)

Added new batch processing demo.

Removed fillers to avoid #178

@shelhamer
Copy link
Member

@rbgirshick @jeffdonahue please review and merge since you know the relation of the wrapper to R-CNN too.

@shelhamer
Copy link
Member

@sguada this needs a rebase.

@sguada
Copy link
Contributor Author

sguada commented Mar 23, 2014

@shelhamer I will wait a bit before doing another rebase, until dev settle down.

@forresti
Copy link
Contributor

Having matcaffe return descriptors with appropriate dims would help me a lot in my current experiments. Any chance we can integrate this PR soon?

@sguada
Copy link
Contributor Author

sguada commented Mar 30, 2014

I will give it another try tomorrow. Hopefully this time gets merged before
dev changes too much and needs rebase again :)

Sergio

2014-03-28 13:04 GMT-07:00 Forrest Iandola [email protected]:

Having matcaffe return descriptors with appropriate dims would help me a
lot in my current experiments. Any chance we can integrate this PR soon?

Reply to this email directly or view it on GitHubhttps://github.com//pull/223#issuecomment-38962166
.

@shelhamer
Copy link
Member

Great Sergio! We'll try to review it soon after it's done :)

Le dimanche 30 mars 2014, Sergio Guadarrama [email protected] a
écrit :

I will give it another try tomorrow. Hopefully this time gets merged before
dev changes too much and needs rebase again :)

Sergio

2014-03-28 13:04 GMT-07:00 Forrest Iandola <[email protected]javascript:_e(%7B%7D,'cvml','[email protected]');

:

Having matcaffe return descriptors with appropriate dims would help me a
lot in my current experiments. Any chance we can integrate this PR soon?

Reply to this email directly or view it on GitHub<
https://github.com/BVLC/caffe/pull/223#issuecomment-38962166>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/223#issuecomment-39038551
.

@sguada
Copy link
Contributor Author

sguada commented Mar 31, 2014

@shelhamer @jeffdonahue @rbgirshick @forresti ready to merge :)

jeffdonahue added a commit that referenced this pull request Apr 2, 2014
@jeffdonahue jeffdonahue merged commit 9b09f59 into BVLC:dev Apr 2, 2014
@jeffdonahue
Copy link
Contributor

Thanks @sguada! Merged. (At some point it would be great to have a few basic unit tests for the MATLAB and Python wrappers.)

@forresti
Copy link
Contributor

forresti commented Apr 2, 2014

Thanks!!! :)
On Apr 2, 2014 10:56 AM, "Jeff Donahue" [email protected] wrote:

Thanks @sguada https://github.com/sguada! Merged. (At some point it
would be great to have a few basic unit tests for the MATLAB and Python
wrappers.)

Reply to this email directly or view it on GitHubhttps://github.com//pull/223#issuecomment-39362080
.

@sguada
Copy link
Contributor Author

sguada commented Apr 2, 2014

Great!! @forresti let me know if you need something else from matcaffe
@jeffdonahue thanks for reviewing and merging

@sguada sguada deleted the improved_matcaffe branch April 2, 2014 18:58
@shelhamer shelhamer mentioned this pull request May 20, 2014
mitmul pushed a commit to mitmul/caffe that referenced this pull request Sep 30, 2014
lukeyeager pushed a commit to lukeyeager/caffe that referenced this pull request Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants