-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matcaffe interface improvements: maintain correct shape, add backward step, and get_weights function #132
Conversation
Double checked, now it works properly. Ready to be merged @rbgirshick @shelhamer |
Please lint and rebase on the latest dev–it no longer merges cleanly. Thanks! |
@shelhamer @jeffdonahue now
|
Also I got another problem when copying the parameters of network
|
Ready to merge @jeffdonahue @shelhamer |
// The end. | ||
{ "END", NULL }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sguada the last entry is supposed to have func set to NULL to terminate the command dispatch loop down on line 354. This change doesn't look safe to me, but maybe I'm missing something?
@shelhamer I haven't been able to figure out yet #178, but if |
@rbgirshick thanks for the catch, I've fixed that. |
@sguada, I can't figure out why this PR isn't updating. I rebased it on the latest How about opening a new PR, closing this one, and commenting with the issue number? We'll continue the review at the new PR. |
@shelhamer done see #223 |
Update Dec 2016
Reshaped outputs of matcaffe forward to keep it parallel to the caffe representation.
Added get_weights from Ross to be able to get the weights from the network.
Added backward to matcaffe inspired by the pycaffe code (not tested yet)