Fix invalid error message on accept terms of use page #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in and they needed to accept the consent on the website, the pa ge reported an error because it expected the tempperm cookie to exist. This is a valid condition and should not generate an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3188
Description of the Change
Instead of generating an error page when the use hasn't selected to use the "Stay Logged In" feature, the website should handle the absence the checkbox and simply create a session cookie. This is done by setting $perm = false instead of generating the error page if the tempperm cookie is not present.
Release Notes
Fix bug causing an error when user did not select "Stay Logged In" and they needed to accept the websites terms of use.