Refactor registration to allow for registration batching #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds commands for new registrations interface. WIP
No QuPath export yet
…ose who require a roi and those who don't. Also adds a way to specify the roi which is macro recordability compatible. Adds a converter from String to RegistrationPair object.
Also, asks for sources preprocessor all the time, for all registrations.
- separate commands from registration sequence - store sources processor in RegistrationPair object - changes hardcoded String by final static public key String
Adds working GUI Increases max size for SIFT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use Warpy like commands in a batchable manner. While the previous Warpy commands are still there for backward compatibility, most of the new Pair Registration commands take their root from ABBA code.
In order to achieve this rewrite, a lot of the registration classes have been moved from ABBA to this repo.
Additionally, a command that use SIFT has been introduced, this allows for a much much better initial guess than the attempted method with elastix working on a very downscaled image.