XML_Toolkit: Rename depth property from XMLDepth to Depth

[rboulton-BH]

NOTE: Depends on

BHoM/Versioning_Toolkit#208

Issues addressed by this PR

Closes #560

Rename Bluebeam depth property from XMLDepth to Depth

Test files

Testing should be carried out using XML test procedure: https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BHoM/XML_Toolkit/XML_Toolkit_PullTest.gh?csf=1&web=1&e=BSk0dH

Changelog

Additional comments

[FraserGreenroyd]

This was a deliberate decision in #555 because of the issue with having a double Depth to make this clear it is the XML String representation of Depth. @CKBoulter added a method to query the numerical Depth to avoid confusion.

As seen in this commit and this subsequent commit.

[FraserGreenroyd]

Following discussion with @rboulton-BH - actions to resolve this PR are as follows:

• Change the default return type of the Query.Depth method to be 0 instead of -1
• Add a description to the Depth property of the Markup object to explain to the user that this is an XML String representation and they may need to use the Query.Depth method to convert to a numerical representation
• Add = Guid.NewGuid(); to the end of the GUID property in XML_oM/Bluebeam/BluebeamObject.cs
• Leave the rename from XMLDepth to Depth - following discussion with @rboulton-BH and explaining the reasoning, he is happy with why the decision was originally made, but is also happy that from the UX perspective for SAP based users (which the Bluebeam pull is for) having the property called Depth, with a suitable description, will not cause an issue with their workflows.

[rboulton-BH]

Changes requested by @FraserGreenroyd have now been made and checked.

[CKBoulter]

Just tested the pull and push tests. All passed after following the procedures.

[FraserGreenroyd]

@BHoMBot check compliance

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 3 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check core
• check null-handling
• check serialisation
• check versioning

There are 16 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 2 requests in the queue ahead of you.

[FraserGreenroyd]

This PR is causing a problem with versioning - @rboulton-BH let's pick up early next week to resolve - should be straight forward but I think it needs a second PR on Versioning_Toolkit to accomplish.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 1 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check installer

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check installer

[FraserGreenroyd]

My changes have been addressed, @CKBoulter has approved functionality.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge