Zero length string now handled for the Depth property

[jamesramsden-bh]

Closes #554

Test files

Try different values of 'depth' in the XML file. Verify the value of 'Depth' in the exploded markup.
test.zip

Changelog

Additional comments

[rboulton-BH]

I've tested the updated code using the sample dwelling and script which is referenced in the original issue. Looks like it's working well now with these changes

[FraserGreenroyd]

@BHoMBot check compliance

[bhombot-ci]

@FraserGreenroyd to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• branch-compliance
• dataset-compliance
• copyright-compliance

There are 260 requests in the queue ahead of you.

[jamesramsden-bh]

@BHoMBot check compliance

[bhombot-ci]

@jamesramsden-bh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[jamesramsden-bh]

@BHoMBot check compliance

[bhombot-ci]

@jamesramsden-bh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 6 requests in the queue ahead of you.

[jamesramsden-bh]

@BHoMBot check required

[bhombot-ci]

@jamesramsden-bh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 2 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[EKAdebo]

Looks like it's working, the data from XML files is coming through as expected.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[jamesramsden-bh]

@BHoMBot check ready-to-merge

[bhombot-ci]

@jamesramsden-bh to confirm, the following actions are now queued:

• check ready-to-merge

[jamesramsden-bh]

@BHoMBot check ready-to-merge

[bhombot-ci]

@jamesramsden-bh to confirm, the following actions are now queued:

• check ready-to-merge

[FraserGreenroyd]

As discussed on a call with @jamesramsden-bh and @CKBoulter just now, agreement to add a Query method to query the double depth to support numerical workflows.

public static double Depth(this Markup markup)
{
    try
    {
        return System.Convert.ToDouble(markup.XMLDepth);
    }
    catch(Exception e)
    {
        BH.Engine.Base.Compute.RecordError("Could not convert XMLDepth to numerical depth.");
        return -1;
    }
}

@rboulton-BH @EKAdebo is a return of -1 for a failed depth suitable here?

[bhombot-ci]

@CKBoulter I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

[bhombot-ci]

@CKBoulter I'm sorry, but I cannot take that instruction from you. As this action would modify this Pull Request, this instruction can only come via an authorised user, per our Code of Conduct for Bots

[FraserGreenroyd]

@BHoMBot fix project file ref. 9695000940

[bhombot-ci]

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 1 requests in the queue ahead of you.

[bhombot-ci]

@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.

[bhombot-ci]

@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

[FraserGreenroyd]

@BHoMBot check compliance

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 4 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check required

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 3 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

@BHoMBot check null-handling

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check null-handling

[FraserGreenroyd]

@BHoMBot check compliance
@BHoMBot check required

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 1 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

Functionality remains the same following @EKAdebo review, new method looks good and works well. Happy to merge to alpha.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge

There are 55 requests in the queue ahead of you.