Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero length string now handled for the Depth property #555

Merged
merged 10 commits into from
Nov 24, 2022
Merged

Zero length string now handled for the Depth property #555

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a49a88b
Zero length texts now handled for the Depth property
jamesramsden-bh May 24, 2022
47d119c
Dodgy setter removed
jamesramsden-bh May 24, 2022
b53c260
XMLDepth as string type
jamesramsden-bh Nov 23, 2022
754e29c
Made XMLDepth virtual
jamesramsden-bh Nov 23, 2022
7481b62
554 Depth Property
CKBoulter Nov 24, 2022
233ae60
554 Depth Property
CKBoulter Nov 24, 2022
5c2f97c
Addressing capitalised issue
CKBoulter Nov 24, 2022
50e52d6
Update XML_Engine/Query/Depth.cs
CKBoulter Nov 24, 2022
4d49a92
Update project compliance
BHoMBot Nov 24, 2022
2ca7352
Fixing null handling
CKBoulter Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions XML_oM/Bluebeam/Markup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,23 @@ public class Markup : BluebeamObject
public virtual string Label { get; set; }

[XmlElement("Depth")]
public virtual double Depth { get; set; }

public string XMLDepth;

public virtual double? Depth
{
get
{
try
{
return Convert.ToDouble(XMLDepth);
}
catch
{
return null;
}
}
}

[XmlElement("Layer")]
public virtual string Layer { get; set; }
}
Expand Down