Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0 Deployment #244

Merged
merged 15 commits into from
Dec 20, 2023
Merged

7.0 Deployment #244

merged 15 commits into from
Dec 20, 2023

Conversation

@FraserGreenroyd FraserGreenroyd added type:compliance Non-conforming to code guidelines type:feature New capability or enhancement and removed type:compliance Non-conforming to code guidelines labels Dec 11, 2023
@FraserGreenroyd FraserGreenroyd self-requested a review December 11, 2023 10:16
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested with the end of milestone test scripts and all is working as expected.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 165 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

There are 71 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs have been reviewed by DevOps and are suitable for the deployment of develop to the 7.0 beta. Approving for merge.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is beta-project-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19833036875

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19833036875

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd I have now provided a passing check on reference 19833036875 as requested.

@FraserGreenroyd FraserGreenroyd merged commit 3d32f8d into main Dec 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants