Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve build issues for Versioning #235

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Resolve build issues for Versioning #235

merged 1 commit into from
Sep 20, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

No description provided.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Sep 20, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Sep 20, 2023
@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review September 20, 2023 08:47
albinber
albinber approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@albinber albinber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked it through with @FraserGreenroyd, approved.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting force checks on: core

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd I have provided force checks to the checks requested.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: copyright-compliance, installer, ready-to-merge, versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit e4bd60e into develop Sep 20, 2023
5 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Versioning-FixBuild branch September 20, 2023 08:54
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albinber albinber albinber approved these changes

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FraserGreenroyd @albinber