Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GetAllElementsVisibleInActiveView #1400

Conversation

vietle-bh
Copy link
Contributor

@vietle-bh vietle-bh commented Aug 30, 2023

Issues addressed by this PR

Closes #1399

Changed linkInstance.Document to linkInstance.GetLinkDocument(). This allows storing Ids of visible elements to the right document.

Test files

Please build this dependent PR and test on this Revit 2020 model called Host.rvt on SharePoint.

image

image

Changelog

Additional comments

@vietle-bh vietle-bh added the type:bug Error or unexpected behaviour label Aug 30, 2023
@vietle-bh vietle-bh self-assigned this Aug 30, 2023
@vietle-bh vietle-bh marked this pull request as ready for review August 30, 2023 14:15
@vietle-bh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

@vietle-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

@vietle-bh to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 38 requests in the queue ahead of you.

@vietle-bh vietle-bh requested a review from pawelbaran August 30, 2023 15:38
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted @vietle-bh, happy to approve the fix 👍

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

2 similar comments
@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@michal-pekacki
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

The check ready-to-merge has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2023

The check ready-to-merge has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran pawelbaran merged commit b27cdb2 into develop Aug 30, 2023
@pawelbaran pawelbaran deleted the Revit_Core_Engine-#1399-FixGetAllElementsVisibleInActiveView branch August 30, 2023 20:17
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
Development

Successfully merging this pull request may close these issues.

GetAllElementsVisibleInActiveView only returns IDs from the main model
3 participants