GetAllElementsVisibleInActiveView only returns IDs from the main model

[vietle-bh]

Description:

GetAllElementsVisibleInActiveView() from ActiveViewVisibilityContext is supposed to return visible element IDs grouped by their host documents. Currently, it only returns IDs from the active document. IDs from links are missing.

Revit_Toolkit/Revit_Core_Engine/Objects/ActiveViewVisibilityContext.cs

Lines 55 to 65 in 796ad08

	[Description("Returns ids of all elements visible in the active view of the host document. The ids are grouped by document they belong to.")]
	public Dictionary<Document, HashSet<ElementId>> GetAllElementsVisibleInActiveView()
	{
	if (m_TargetDocument != null)
	{
	BH.Engine.Base.Compute.RecordError($"The context has been processed with a single target document. Please run again making sure that the target document parameter in the context constructor is null.");
	return null;
	}
	else
	return m_DocumentLookup.ToDictionary(x => x.Value, x => m_Elements[x.Key]);
	}

Steps to reproduce:

Run the method on any Revit file with a visible link in the current view to observe the symptom above. This is because m_DocumentLookup[linkInstance.Document.PathName] = linkInstance.Document; in the method below wont' add the link's document to m_DocumentLookup. linkInstance.Document should have been linkInstance.GetLinkDocument().

Revit_Toolkit/Revit_Core_Engine/Objects/ActiveViewVisibilityContext.cs

Lines 94 to 111 in 796ad08

	public RenderNodeAction OnElementBegin(ElementId elementId)
	{
	Document doc = m_Documents.Peek();
	m_Elements[doc.PathName].Add(elementId);
	Element element = doc.GetElement(elementId);
	if (element is RevitLinkInstance)
	{
	RevitLinkInstance linkInstance = (RevitLinkInstance)element;
	if (m_TargetDocument == null || m_TargetDocument.PathName == linkInstance.GetLinkDocument().PathName)
	{
	m_DocumentLookup[linkInstance.Document.PathName] = linkInstance.Document;
	return RenderNodeAction.Proceed;
	}
	}
	return RenderNodeAction.Skip;
	}

Expected behaviour:

Test file(s):