Messaging tweaked and bug in roof push fixed

[pawelbaran]

Issues addressed by this PR

Closes #1283
Closes #1284
Closes #1286

Test files

On SharePoint

Changelog

Additional comments

[pawelbaran]

Oh, please do not review yet @michal-pekacki @vietle-bh, I will have a look at the errors in the pull of panels first - will let you know when ready to review 👍

[pawelbaran]

Oke, I have pushed one more commit + added new test file. Ready for review now 👍

[vietle-bh]

It's a huge improvement! This is before the fix:

And this is after:

The remaining errors seem to be around here;

Will we fix this in this PR?

[pawelbaran]

Thanks @vietle-bh for review. I have addressed all of your comments, should be ready for re-review now

[vietle-bh]

Thanks @vietle-bh for review. I have addressed all of your comments, should be ready for re-review now

Great! Which Grasshopper script should I use to test the Push though?
(I tested before only with a Pull script)

[vietle-bh]

By the way @pawelbaran , I found a related issue while testing: #1286
It would be good to fix it too 😅

[pawelbaran]

Great! Which Grasshopper script should I use to test the Push though? (I tested before only with a Pull script)

The test files are here: #1285-MessageTweaks shows the tweaks to push, #1285-PullPanelFix shows the tweaks to pull

[pawelbaran]

I have also fixed #1286 @vietle-bh - I hope all covered now 🙈

[pawelbaran]

@BHoMBot check core
@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check core
• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[pawelbaran]

@BHoMBot check core
@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check core
• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 13 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check core

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check core

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[vietle-bh]

The test files are here: #1285-MessageTweaks shows the tweaks to push, #1285-PullPanelFix shows the tweaks to pull

Thanks. It works great with both your test files and mine 👍

[vietle-bh]

I have also fixed #1286 @vietle-bh - I hope all covered now 🙈

There're definitely fewer errors now 👍 However, some items fail on another null exception due to nurbs curves in their boundaries.

Error 1 already gives enough info so it would be good to maybe hide the second error:

[pawelbaran]

There're definitely fewer errors now 👍 However, some items fail on another null exception due to nurbs curves in their boundaries.

Thanks @vietle-bh for reviewing - but please stop finding new-old issues that I have not covered! 😃 This one should actually be fixed on the engine side, please see #1287.

So when it comes to this PR, I think it should be fine to approve/merge if you do not find any other bits worth fixing before the Beta release.

[vietle-bh]

Approved based on the conversation above.

[pawelbaran]

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check copyright-compliance
• check ready-to-merge