Edge case error on convert from Revit roof to structural panel

[pawelbaran]

Description:

Following this comment by @vietle-bh, an error occurs on pull of the roof below from the standard test file.

The bottom of the issue lies in the fact that BH.Engine.Structure.Create.Panel method does not take geometrical tolerance as input, causing the Revit outline to be considered as not closed (even though it is acc. to Revit). Issue on BHoM_Engine raised under BHoM/BHoM_Engine#2961 - once it gets resolved, Revit tolerance will need to be passed in the line below (and in all other panel creation calls).

Revit_Toolkit/Revit_Core_Engine/Convert/Structure/FromRevit/Panels.cs

Line 140 in 3c0ec50

result.Add(BHS.Create.Panel(planarSurface.ExternalBoundary.ITranslate(translation), internalBoundaries, property2D, null, hostObject.Name));

[pawelbaran]

I have debugged this issue after BHoM/BHoM_Engine#2961 got fixed and it still occurs - after digging deeper, it turned out that the problem lies in wrong face geometry being queried from the roof. There are two aspects here:

• some faces of the element are nonplanar
• some planar faces have hermite splines and nurbs curves as edges, which fail to convert

First point can be addressed by adding a meaningful message (to be PRed after the feature freeze), the other is a deeper issue that requires more work, already captured under #798.