Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version check to existing environment query #126

Merged

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Nov 27, 2023

Issues addressed by this PR

Closes #125

Removed all mention of C:\ProgramData in favour of environment variables where possible, and added means of checking existing virtual Python env versions against a target version number.

Test files

Changelog

Additional comments

@tg359 tg359 added size:S Measured in minutes type:feature New capability or enhancement priority:low Resources should be targeted to other issues first labels Nov 27, 2023
@tg359 tg359 self-assigned this Nov 27, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good on code review, deploying for alpha testing in the morning.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 16 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Nov 27, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 27, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 27, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 27, 2023

@tg359 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on LadybugTools_Toolkit

1 similar comment
Copy link

bhombot-ci bot commented Nov 27, 2023

@tg359 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on LadybugTools_Toolkit

Copy link

bhombot-ci bot commented Nov 27, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving following versioning fix. As installer passed on LBT and versioning passed (which requires the same), installer was dispensated for speed to get these into the alpha for testing tomorrow.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 94dc680 into develop Nov 27, 2023
11 of 12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#125_VirtualEnvironmentVersionCheck branch November 27, 2023 23:11
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Resources should be targeted to other issues first size:S Measured in minutes type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check to VirtualEnvironmentExists to see if existing Python version matches target Python version
2 participants