-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added version check to existing environment query #151
Added version check to existing environment query #151
Conversation
…tion version method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good on code review, deploying for alpha testing in the morning.
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
The check |
@tg359 just to let you know, I have provided a |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
NOTE: Depends on
BHoM/Python_Toolkit#126
Issues addressed by this PR
Closes #150
Pollination version now obtained from a different file which makes ascertaining version installed a bit simpler. Also, logic for returning an existing environment modified to incorporate changes in Python_Toolkit (issue above). This should partially stop some of the weird issues where users have differing versions of tools installed that makes behaviour less predictable, and align all using one single version - forcing a reinstall of the target software if required.
Test files
Changelog
Additional comments