Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version check to existing environment query #151

Merged

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Nov 27, 2023

NOTE: Depends on

BHoM/Python_Toolkit#126

Issues addressed by this PR

Closes #150

Pollination version now obtained from a different file which makes ascertaining version installed a bit simpler. Also, logic for returning an existing environment modified to incorporate changes in Python_Toolkit (issue above). This should partially stop some of the weird issues where users have differing versions of tools installed that makes behaviour less predictable, and align all using one single version - forcing a reinstall of the target software if required.

Test files

Changelog

Additional comments

@tg359 tg359 added severity:medium Slows progress, but workaround is possible size:S Measured in minutes type:bug Error or unexpected behaviour labels Nov 27, 2023
@tg359 tg359 self-assigned this Nov 27, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good on code review, deploying for alpha testing in the morning.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check installer
@BHoMBot check compliance
@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Nov 27, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 27, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 27, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 27, 2023

@tg359 just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Python_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

Copy link

bhombot-ci bot commented Nov 27, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 08828e0 into develop Nov 27, 2023
12 of 13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#125_VirtualEnvironmentVersionCheck branch November 27, 2023 23:11
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:medium Slows progress, but workaround is possible size:S Measured in minutes type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure version of Python matches current target version within local Venv installer
2 participants