-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed file and added needed attributes #109
Renamed file and added needed attributes #109
Conversation
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attribute changes are fine. Tom also demonstrated that the PR builds successfully and loads the new attributes in Grasshopper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are in line with issue, happy to deploy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed my mind, as we're providing a definitive executable path, it should be for the definitive version I think.
Co-authored-by: Fraser Greenroyd <[email protected]>
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving following application of suggested changes.
@BHoMBot check copyright-compliance |
@jamesramsden-bh to confirm, the following actions are now queued:
|
Requested change was a simple word change and has now been addressed
@BHoMBot check versioning |
@jamesramsden-bh to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Fixes #108
Added attributes to the version method and changed the file name to Version.cs.
Test files
Check BH.Engine.Python.Query.Version in grasshopper to see if the attributes have been updated.
Additional comments
Added punctuation to ToString.cs attributes