Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed file and added needed attributes #109

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

Tom-Kingstone
Copy link
Contributor

Fixes #108
Added attributes to the version method and changed the file name to Version.cs.

Test files

Check BH.Engine.Python.Query.Version in grasshopper to see if the attributes have been updated.

Additional comments

Added punctuation to ToString.cs attributes

@Tom-Kingstone Tom-Kingstone added the type:documentation Wiki, help or in code attributes label Aug 29, 2023
@Tom-Kingstone Tom-Kingstone added this to the BHoM 6.3 β MVP milestone Aug 29, 2023
@Tom-Kingstone Tom-Kingstone self-assigned this Aug 29, 2023
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attribute changes are fine. Tom also demonstrated that the PR builds successfully and loads the new attributes in Grasshopper.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are in line with issue, happy to deploy.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind, as we're providing a definitive executable path, it should be for the definitive version I think.

Python_Engine/Query/Version.cs Outdated Show resolved Hide resolved
Co-authored-by: Fraser Greenroyd <[email protected]>
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving following application of suggested changes.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check copyright-compliance

@jamesramsden-bh jamesramsden-bh dismissed FraserGreenroyd’s stale review August 29, 2023 13:53

Requested change was a simple word change and has now been addressed

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit d5bad7c into develop Aug 29, 2023
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#108-MissingAttributes branch August 29, 2023 14:13
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Wiki, help or in code attributes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing attributes for query.version
3 participants