Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing attributes for query.version #108

Closed
Tom-Kingstone opened this issue Aug 29, 2023 · 0 comments · Fixed by #109
Closed

Missing attributes for query.version #108

Tom-Kingstone opened this issue Aug 29, 2023 · 0 comments · Fixed by #109
Assignees
@Tom-Kingstone
Labels
type:documentation Wiki, help or in code attributes
Milestone
BHoM 6.3 β MVP

Comments

@Tom-Kingstone
Copy link
Contributor

Tom-Kingstone commented Aug 29, 2023 •
edited
Loading

Broken rules:

missing attributes for Query.Version.
Query.Version does not sit in a correctly named file (currently PythonVersion.cs)

Suggestions to restore compliance:

Rename file from PythonVersion.cs to Version.cs
add description, input and output attributes:

description - gets the python version for a requested Python executable
pythonExecutable - Path to python.exe
output - version - Python version
@Tom-Kingstone Tom-Kingstone added the type:compliance Non-conforming to code guidelines label Aug 29, 2023
@Tom-Kingstone Tom-Kingstone added this to the BHoM 6.3 β MVP milestone Aug 29, 2023
@Tom-Kingstone Tom-Kingstone self-assigned this Aug 29, 2023
@Tom-Kingstone Tom-Kingstone added type:documentation Wiki, help or in code attributes and removed type:compliance Non-conforming to code guidelines labels Aug 29, 2023
@Tom-Kingstone Tom-Kingstone mentioned this issue Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Kingstone Tom-Kingstone

Labels
type:documentation Wiki, help or in code attributes
Projects
None yet
Milestone
BHoM 6.3 β MVP
Development

Successfully merging a pull request may close this issue.

Renamed file and added needed attributes BHoM/Python_Toolkit
1 participant
@Tom-Kingstone