-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Psychrometrics_Toolkit: Unit Compliance #55
Psychrometrics_Toolkit: Unit Compliance #55
Conversation
@albinber to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the typeof(Temperature)
quantity attributes available from BH.oM.Quantity
available here, rather than putting the units in brackets in the input descriptions 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add BHoM/Localisation_Toolkit
as a dependency in the dependencies.txt
file 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See initial comments - spaces after the ,
on attribute inputs across the board please - I did the first file then realised it's a pattern so putting back on @albinber and @Tom-Kingstone to resolve please 😄
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 65 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 44 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
@BHoMBot check core |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check core |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check core |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
Co-authored-by: Fraser Greenroyd <[email protected]>
Co-authored-by: Fraser Greenroyd <[email protected]>
Co-authored-by: Fraser Greenroyd <[email protected]>
Co-authored-by: Fraser Greenroyd <[email protected]>
Co-authored-by: Fraser Greenroyd <[email protected]>
Co-authored-by: Fraser Greenroyd <[email protected]>
Co-authored-by: Fraser Greenroyd <[email protected]>
Co-authored-by: Fraser Greenroyd <[email protected]>
7d26a70
to
9ce8b6d
Compare
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, installer, null-handling, serialisation, versioning, ready-to-merge |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still all good following rebase
NOTE: Depends on
Issues addressed by this PR
Closes #39
Test files
Changelog
Additional comments