Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolkit is not unit compliant #39

Closed
travispotterBH opened this issue Dec 21, 2022 · 0 comments · Fixed by #55
Closed

Toolkit is not unit compliant #39

travispotterBH opened this issue Dec 21, 2022 · 0 comments · Fixed by #55
Assignees
@jamesramsden-bh
Labels
type:compliance Non-conforming to code guidelines

Comments

@travispotterBH
Copy link

Broken rules:

The base SI unit for temperature in the BHoM is Kelvin per:
https://github.com/BHoM/BHoM/blob/aeb89ef53b6183e8a3865f413e2016404e8a823f/Quantities_oM/Attributes/Temperature.cs#L27-L38

Suggestions to restore compliance:

Modify all methods that use temperature as an input or output, modify to the correct unit, K.
@travispotterBH travispotterBH added the type:compliance Non-conforming to code guidelines label Dec 21, 2022
@FraserGreenroyd FraserGreenroyd removed their assignment Dec 22, 2022
albinber added a commit that referenced this issue Sep 4, 2023
@albinber
Merge branch 'Psychrometrics_Toolkit-#39-UnitCompliance' of https://g…
a60a49c 
…ithub.com/BHoM/Psychrometrics_Toolkit into Psychrometrics_Toolkit-#39-UnitCompliance
Tom-Kingstone added a commit that referenced this issue Sep 4, 2023
@Tom-Kingstone
Merge branch 'Psychrometrics_Toolkit-#39-UnitCompliance' of https://g…
41fb92b 
…ithub.com/BHoM/Psychrometrics_Toolkit into Psychrometrics_Toolkit-#39-UnitCompliance
@albinber albinber mentioned this issue Sep 4, 2023
Merged
FraserGreenroyd pushed a commit that referenced this issue Sep 5, 2023
Merge branch 'develop' into Psychrometrics_Toolkit-#39-UnitCompliance
247edfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesramsden-bh jamesramsden-bh

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Psychrometrics_Toolkit: Unit Compliance BHoM/Psychrometrics_Toolkit
3 participants
@FraserGreenroyd @jamesramsden-bh @travispotterBH