-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined methods with similar inputs #54
Combined methods with similar inputs #54
Conversation
@BHoMBot check core |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check code-compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
The check |
The check |
The check |
The check |
The check |
@BHoMBot check compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense following call and walk through with @Tom-Kingstone and @jamesramsden-bh - happy to deploy
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #52
Closes #12
Three methods have been created: FromHumidityRatio, FromRelativeHumidity and FromWetBulbTemperature.
These methods take in dryBulbTemperature and pressure (with a default to air pressure at sea level), as well as a third input of: humidityRatio, relativeHumidity or wetBulbTemperature.
They then output density, enthalpy, dew-point temperature, humidity ratio, relative humidity, specific volume and wet-bulb temperature. These methods each replace 6 previous methods (18 in total) in functionality, as well as improving user experience searching for methods from the psychrometrics toolkit.
Additionally, moved methods DensityWater, SaturatedVapourPressureWater and SpecificHeatCapacityWater into Psychrometrics Toolkit. (as per issue #12)
Test files
Psychrometrics_Toolkit.zip
(the new methods are on the top right of the script, and use the same values to test as the old methods)
Additional comments