Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined methods with similar inputs #54

Merged
merged 4 commits into from
Sep 4, 2023

Conversation

Tom-Kingstone
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone commented Sep 1, 2023

Issues addressed by this PR

Closes #52
Closes #12

Three methods have been created: FromHumidityRatio, FromRelativeHumidity and FromWetBulbTemperature.
These methods take in dryBulbTemperature and pressure (with a default to air pressure at sea level), as well as a third input of: humidityRatio, relativeHumidity or wetBulbTemperature.
They then output density, enthalpy, dew-point temperature, humidity ratio, relative humidity, specific volume and wet-bulb temperature. These methods each replace 6 previous methods (18 in total) in functionality, as well as improving user experience searching for methods from the psychrometrics toolkit.

Additionally, moved methods DensityWater, SaturatedVapourPressureWater and SpecificHeatCapacityWater into Psychrometrics Toolkit. (as per issue #12)

Test files

Psychrometrics_Toolkit.zip
(the new methods are on the top right of the script, and use the same values to test as the old methods)

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:feature New capability or enhancement label Sep 1, 2023
@Tom-Kingstone Tom-Kingstone added this to the BHoM 6.3 β MVP milestone Sep 1, 2023
@Tom-Kingstone Tom-Kingstone self-assigned this Sep 1, 2023
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check code-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance

There are 2 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

There are 8 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

There are 19 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 1 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 7 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@Tom-Kingstone Tom-Kingstone marked this pull request as ready for review September 4, 2023 08:03
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense following call and walk through with @Tom-Kingstone and @jamesramsden-bh - happy to deploy

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 4, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 1f61095 into develop Sep 4, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Psychrometrics_Toolkit-#52-CombineMethods branch September 4, 2023 11:05
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
2 participants