Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move methods from Climate Toolkit into Psychrometrics Toolkit #12

Closed
3 tasks done
vbeardow opened this issue Aug 6, 2020 · 2 comments · Fixed by #54
Closed
3 tasks done

Move methods from Climate Toolkit into Psychrometrics Toolkit #12

vbeardow opened this issue Aug 6, 2020 · 2 comments · Fixed by #54
Assignees
@EKAdebo @Tom-Kingstone
Labels
severity:low Doesn't stop/slow current workflow size:M Measured in hours type:feature New capability or enhancement
Milestone
BHoM 6.1 β MVP

Comments

@vbeardow
Copy link

vbeardow commented Aug 6, 2020 •
edited by Tom-Kingstone
Loading

Description:

Add the following methods from Climate toolkit into Psychrometrics, following discussion on https://github.com/BuroHappoldEngineering/Climate_Toolkit/issues/204

  • DensityWater
  • SpecificHeatCapacityWater
  • SaturatedVapourPressureWater

Either replace with code previously in climate toolkit or with respective Psychrolib methods.

Ensure documentation and QA/QC is complete and up-to-date for the methods.
@vbeardow vbeardow added severity:low Doesn't stop/slow current workflow size:M Measured in hours type:feature New capability or enhancement labels Aug 6, 2020
@rboulton-BH rboulton-BH added this to the BHoM 6.1 β MVP milestone Dec 22, 2022
@tg359
Copy link

tg359 commented Jan 4, 2023 •
edited
Loading

@EKAdebo - these links should help you

Here are the methods in Climate_Toolkit currently that could be moved over:

Or, even better than that, you could use the Psychrolib nuget package we have access to in this repository to create new methods - here is an example for calculating Enthalpy from HumidityRatio in this toolkit currently (if those features exist in it).

@EKAdebo EKAdebo assigned EKAdebo and unassigned EKAdebo Feb 9, 2023
@FraserGreenroyd
Copy link

[PreviousVersion("6.2", "BH.Engine.Climate.Compute.DensityWater(System.Double)")]

Needed for all methods moved.

Tom-Kingstone added a commit that referenced this issue Sep 1, 2023
@Tom-Kingstone
(#12) moved methods from climate toolkit
8af8de9
@Tom-Kingstone Tom-Kingstone mentioned this issue Sep 1, 2023
Merged
FraserGreenroyd pushed a commit that referenced this issue Sep 4, 2023
@Tom-Kingstone
(#12) moved methods from climate toolkit
1f61095
FraserGreenroyd pushed a commit that referenced this issue Sep 11, 2023
@Tom-Kingstone
(#12) moved methods from climate toolkit
276ba3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EKAdebo EKAdebo

@Tom-Kingstone Tom-Kingstone

Labels
severity:low Doesn't stop/slow current workflow size:M Measured in hours type:feature New capability or enhancement
Projects
Building Environments Priority
Status: Completed
Milestone
BHoM 6.1 β MVP
6 participants
@tg359 @FraserGreenroyd @rboulton-BH @vbeardow @EKAdebo @Tom-Kingstone