Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nuget #12

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

travispotterBH
Copy link

@travispotterBH travispotterBH commented Jan 17, 2024

NOTE: Depends on BHoM/Excel_Toolkit#58

Issues addressed by this PR

Closes #8

Test files

Changelog

Additional comments

@travispotterBH travispotterBH added the type:bug Error or unexpected behaviour label Jan 17, 2024
@travispotterBH travispotterBH self-assigned this Jan 17, 2024
Copy link

@JohannaOlin1 JohannaOlin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the workflow where the issue described in #8 was discovered, which is now working

@FraserGreenroyd
Copy link

@BHoMBot check compliance
@BHoMBot check required

Copy link

bhombot-ci bot commented Jan 18, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 7 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jan 18, 2024

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 18, 2024

This repository is not part of the beta package and does not require a versioning check to be performed.

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jan 18, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit d13c146 into develop Jan 18, 2024
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the PowerPoint_Toolkit-#8-ClosedXMLVersion branch January 18, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocumentFormat_OpenXML not compliant with PowerPoint_Toolkit
3 participants