Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClosedXML Version Updated #58

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

travispotterBH
Copy link

Issues addressed by this PR

Closes #57

Test files

Changelog

Additional comments

@travispotterBH travispotterBH added the type:bug Error or unexpected behaviour label Jan 17, 2024
@travispotterBH travispotterBH self-assigned this Jan 17, 2024
@travispotterBH
Copy link
Author

@BHoMBot check core
@BHoMBot check installer

Copy link

bhombot-ci bot commented Jan 17, 2024

@travispotterBH to confirm, the following actions are now queued:

  • check core
  • check installer

@FraserGreenroyd
Copy link

@BHoMBot check versioning
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 18, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link

@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Jan 18, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on this review

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jan 18, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit ca4c39c into develop Jan 18, 2024
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-#57-ClosedXMLVersions branch January 18, 2024 20:57
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClosedXML version issue causing crashing when using export to excel in dependent toolkits
2 participants